Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Inject the RemoteStoreRefreshListener in the indexShard constructor #3548

Closed
sachinpkale opened this issue Jun 9, 2022 · 1 comment
Closed

[Remote Store] Inject the RemoteStoreRefreshListener in the indexShard constructor #3548

sachinpkale opened this issue Jun 9, 2022 · 1 comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@sachinpkale
Copy link
Member

sachinpkale commented Jun 9, 2022 •
edited
Loading

This change resolves #3460 (comment) and #3460 (comment)

This change also involves creating NoOpRemoteStoreRefreshListener for replicas. Based on primary/replica, corresponding implementation of RemoteStoreRefreshListener will be injected.
@sachinpkale sachinpkale added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 9, 2022
This was referenced Jun 9, 2022
Open
Merged
@sachinpkale sachinpkale changed the title [Remote Store] Create NoOpRemoteStoreRefreshListener for replicas [Remote Store] Create NoOpRemoteStoreRefreshListener for replicas and inject the RemoteStoreRefreshListener in the indexShard constructor Jun 9, 2022
@sachinpkale sachinpkale changed the title [Remote Store] Create NoOpRemoteStoreRefreshListener for replicas and inject the RemoteStoreRefreshListener in the indexShard constructor [Remote Store] Inject the RemoteStoreRefreshListener in the indexShard constructor Jun 9, 2022
@sachinpkale sachinpkale mentioned this issue Jun 25, 2022
Merged
5 tasks
@sachinpkale
Copy link
Member Author

PR link: #3703

@Bukhtawar Bukhtawar mentioned this issue Jul 21, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sachinpkale @xuezhou25