Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Merge to main tracking - Refactoring of existing classes to support segrep. #2926

Closed
5 tasks done
Tracked by #2355
mch2 opened this issue Apr 15, 2022 · 3 comments
Closed
5 tasks done
Tracked by #2355

[Segment Replication] Merge to main tracking - Refactoring of existing classes to support segrep. #2926

mch2 opened this issue Apr 15, 2022 · 3 comments
Assignees
@Poojita-Raj @Rishikesh1159 @kartg

Comments

@mch2
Copy link
Member

mch2 commented Apr 15, 2022 •
edited by kotwanikunal
Loading

This is a tracking task for the refactoring tasks outlined in our meta merging issue.

  • Move RecoveryIndex to top level class and move inner classes from RecoveryIndex
  • Move RecoveryState.Timer to top level
  • Change GatedAutoCloseable to AutoCloseableRefCounted
  • Create base class ReplicationTarget and refactor RecoveryTarget to inherit from it.
  • Engine interface changes for addIndexOperationToTranslog and addDeleteOperationToTranslog
@mch2 mch2 added bug Something isn't working untriaged and removed bug Something isn't working untriaged labels Apr 15, 2022
@mch2 mch2 mentioned this issue Apr 15, 2022
Closed
11 tasks
@kartg
Copy link
Member

kartg commented Apr 15, 2022

Move RecoveryIndex to top level class and move inner classes from RecoveryIndex
Move RecoveryState.Timer to top level
Change GatedAutoCloseable to AutoCloseableRefCounted

I can pick these up

@kartg kartg mentioned this issue Apr 18, 2022
Merged
5 tasks
@kartg
Copy link
Member

kartg commented Apr 18, 2022

Move RecoveryState.Timer to top level
Change GatedAutoCloseable to AutoCloseableRefCounted

PR - #2965

This was referenced Apr 19, 2022
Closed
Closed
@kartg
Copy link
Member

kartg commented Apr 25, 2022

Move RecoveryIndex to top level class and move inner classes from RecoveryIndex

PR - #3075

@mch2 mch2 mentioned this issue Apr 29, 2022
Closed
@Rishikesh1159 Rishikesh1159 mentioned this issue May 6, 2022
Merged
5 tasks
@Poojita-Raj Poojita-Raj mentioned this issue May 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poojita-Raj Poojita-Raj

@Rishikesh1159 Rishikesh1159

@kartg kartg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mch2 @kotwanikunal @Poojita-Raj @Rishikesh1159 @kartg