Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue template with multiple labels #333

Merged
merged 1 commit into from
May 10, 2021

Conversation

VachaShah
Copy link
Contributor

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

This PR intends to add multiple labels for the issue template to better categorize the issues.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5736299

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VachaShah Thanks for the PR, one small comment otherwise LGTM !

@@ -2,7 +2,7 @@
name: 🐛 Bug report
about: Create a report to help us improve
title: "[BUG]"
labels: bug
labels: 'bug, untriaged, Beta'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tag beta by default ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tags "untriaged" and "Beta" will be added by default since it is part of this file. These tags need to be added to the Labels list in the repository by the maintainers so that they are attached to each newly created issue by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it mean, we'll change this beta tag for after each release?

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes @VachaShah

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 3f4eb6e into opensearch-project:main May 10, 2021
@VachaShah VachaShah deleted the update_template branch May 11, 2021 05:43
kavilla pushed a commit that referenced this pull request May 21, 2021
Signed-off-by: Vacha Shah <vachshah@amazon.com>

Co-authored-by: Vacha Shah <vachshah@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024
…earch-project#6378) (opensearch-project#333)

* Allow workspace update with partial attirbutes



* Add permissions tab for workspace creator and update page



* Add change log for adding permission tab



* Optimize permissions to permissions settings convertation



* Address PR comments



* Update comments for getPermissionModeId



---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
…earch-project#6378) (opensearch-project#333)

* Allow workspace update with partial attirbutes



* Add permissions tab for workspace creator and update page



* Add change log for adding permission tab



* Optimize permissions to permissions settings convertation



* Address PR comments



* Update comments for getPermissionModeId



---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants