Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-Next][UI] Query editor darkmode highlight bad contrast #7037

Open
Tracked by #6957
kavilla opened this issue Jun 15, 2024 · 0 comments
Open
Tracked by #6957

[Discover-Next][UI] Query editor darkmode highlight bad contrast #7037

kavilla opened this issue Jun 15, 2024 · 0 comments

Comments

@kavilla
Copy link
Member

kavilla commented Jun 15, 2024

Description

Query editor automatically highlights the query, making it difficult to see. Also while highlighting it's not properly styling to a darker text.

Steps to recreate

  • Start OpenSearch Dashboards with query enhancements enabled and toggled on. Also select dark mode.
  • Navigate to Discover
  • Select a language that populates the query editor with a non-empty query by default
  • Notice the highlighting:
    Screenshot 2024-06-15 at 4 41 02 PM

Requirements

  • Query editor text is not selected by default when switching languages
  • Regardless, if a user highlights the text, the text should still be readable in dark mode.
@kavilla kavilla changed the title Defaults to highlighting syntax, making it unreadable [Defaults to highlighting syntax, making it unreadable Jun 15, 2024
@kavilla kavilla changed the title [Defaults to highlighting syntax, making it unreadable [Discover-Next][UI] Query editor darkmode highlight bad contrast Jun 16, 2024
@kavilla kavilla closed this as completed Sep 12, 2024
@kavilla kavilla reopened this Sep 12, 2024
@kavilla kavilla added v2.17.0 and removed v2.16.0 labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant