Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] data source connection link in Index pattern table breaks #6581

Closed
Tracked by #5872
zhongnansu opened this issue Apr 22, 2024 · 4 comments
Closed
Tracked by #5872

[BUG] data source connection link in Index pattern table breaks #6581

zhongnansu opened this issue Apr 22, 2024 · 4 comments
Assignees
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Apr 22, 2024

Describe the bug

data source connection link in Index pattern table is not working as expected. It fails to redirect to the corresponding data source detail page, instead it goes to the dashboards management landing page

Screenshots

iShot_2024-04-21_23 18 23

@zhongnansu zhongnansu added bug Something isn't working untriaged labels Apr 22, 2024
@zhongnansu
Copy link
Member Author

zhongnansu commented Apr 22, 2024

I'll work on this

The issue is with the DSM_APP_ID was wrongly changed to dataSourceManagement with my recent PR to main.

export const DSM_APP_ID = 'dataSourceManagement';

It's supposed to be DSM_APP_ID = dataSources, and then during plugin registration , it will have the following url,

/app/management/opensearch-dashboards/dataSources/<data source id>

which semantically makes more sense than

/app/management/opensearch-dashboards/dataSourceManagement/<data source id>

cc: @BionIT

@zhongnansu zhongnansu added multiple datasource multiple datasource project v2.14.0 labels Apr 22, 2024
@seraphjiang
Copy link
Member

The issue is with the link url. Currently it's

/app/management/opensearch-dashboards/dataSourceManagement/<data source id>

it should be

/app/management/opensearch-dashboards/dataSourceManagement/<data source id>

dataSourceManagement is the data source management plugin id

Hi @zhongnansu the actual and expected Url seems identical, would you check

@zhongnansu
Copy link
Member Author

zhongnansu commented Apr 22, 2024

@seraphjiangsorry actually the url should be

/app/management/opensearch-dashboards/dataSources/<data source id>

I updated my comment, please take a look

@zhongnansu
Copy link
Member Author

fixed by PR ##6604, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0
Projects
None yet
Development

No branches or pull requests

3 participants