Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Support workspace level ui settings #6509

Closed
2 tasks
ruanyl opened this issue Apr 17, 2024 · 2 comments
Closed
2 tasks

[Workspace] Support workspace level ui settings #6509

ruanyl opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request workspace

Comments

@ruanyl
Copy link
Member

ruanyl commented Apr 17, 2024

Is your feature request related to a problem? Please describe.

Workspace is a newly introduced feature to OpenSearch-Dashboards which allows user to manage saved objects isolated by workspaces. There is the need to have some ui settings be customized for an individual workspace instead of having that configured globally( via Advance settings).

Also, ui settings such as default index pattern is going to be problematic under workspace if there is only one global value, because index patterns are workspace-isolated objects, sharing a single global value will not work for all workspaces. This issue is created initially to resolve this problem.

This is part of the story of System settings, Workspace settings and User settings, more details could be found here #4298. For now, we will start with an implementation which has the minimum impact to the rest of the system and keep it flexible for future changes. There are a few open questions are listed below.

Describe the solution you'd like

When calling uiSettings.set within a workspace, the value will be set to the current workspace(as a property of the workspace object) instead of the global config object. And calling uiSettings.get will return the value of the current workspace if the value is set, otherwise, the global value is returned.

Open questions

  • How to handle workspace ui settings export and import?
  • Is workspace settings migration necessary?

Describe alternatives you've considered

Not yet

Additional context

#4298

@ruanyl ruanyl added enhancement New feature or request workspace labels Apr 17, 2024
@ruanyl ruanyl self-assigned this Apr 17, 2024
@BionIT
Copy link
Collaborator

BionIT commented Jun 4, 2024

@ruanyl Looks like the PR has been merged as part of 2.14, is this issue done?

@ruanyl
Copy link
Member Author

ruanyl commented Jun 4, 2024

@BionIT Thanks, closing now

@ruanyl ruanyl closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workspace
Projects
None yet
Development

No branches or pull requests

2 participants