Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] data_source.hideLocalCluster setting and default datasource is not being honored when mounting data source menu via Top Nav Menu #6368

Closed
Tracked by #5872
zhongnansu opened this issue Apr 8, 2024 · 1 comment
Assignees
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Apr 8, 2024

Describe the bug

Coming from discussion here. Currently when mounting data source menu via Top Nav Menu,

  • it fails to use the data_source.hideLocalCluster setting in data source plugin config to decide if to hide/show local cluster.
  • It fails to render default label of options in any data source picker/selectors.

This is related to how DataSourceMenu is consumed in navigation plugin, it's currently imported directly, instead of using the data source management plugin API, const DataSourceMenu = this.props.dataSourceManagement.ui.getDataSourceMenu<DataSourceMultiSelectableConfig>();.

import { DataSourceMenu, DataSourceMenuProps } from '../../../data_source_management/public';

To Reproduce
Steps to reproduce the behavior:
0. enabled data source plugin and set data_source.hideLocalCluster: true

  1. yarn start --run-examples
  2. create a datasource,
  3. go to Data Source List All Component Mounted Via TopNavMenu Example, from the data source picker on the top right, it doesn't show any default label of any options, and it still shows local cluster
    image

Expected behavior
A clear and concise description of what you expected to happen.

OpenSearch Version
Please list the version of OpenSearch being used.

Dashboards Version
Please list the version of OpenSearch Dashboards being used.

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@zhongnansu zhongnansu added bug Something isn't working enhancement New feature or request untriaged multiple datasource multiple datasource project and removed enhancement New feature or request labels Apr 8, 2024
@ananzh ananzh removed the untriaged label Apr 9, 2024
@BionIT BionIT added the v2.14.0 label Apr 22, 2024
@BionIT
Copy link
Collaborator

BionIT commented Apr 22, 2024

I think this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0
Projects
None yet
Development

No branches or pull requests

3 participants