Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Disambiguous datasource for OSD developer and OSD plugin developer #6039

Open
2 tasks
seraphjiang opened this issue Mar 5, 2024 · 2 comments
Open
2 tasks
Assignees
Labels
bug Something isn't working multiple datasource multiple datasource project

Comments

@seraphjiang
Copy link
Member

seraphjiang commented Mar 5, 2024

Today, there are two datasources in OSD which cause confusion.

One is direct datasource we introduced in 2.4, another is datasource introduced with observability which is not direct datasource in OSD. It won't work without observability plugin and a few backend plugin.

We propose only one data source concept in OSD, that means we need to centralized storage, management API, UI for the datasource.

Storage: the datasource meta info will be persist into .kibana or other supported meta storage

API: all datasource must be managed via saved-object API

Management UI: all datasource must be managed via DataSource management in Dashboards Management.
e.g.
https://playground.opensearch.org/app/management/opensearch-dashboards/dataSources

Below is the tasks to track the effort to fix the issue across opensource project

OSD:

Observability:
Move the observability datasource management from top left nav menu, it should move into observability dedicated page for short term. for long term, it should rewrite and merge into dashboards's build in datasource management. tracking progress here
opensearch-project/dashboards-observability#1469

@seraphjiang seraphjiang added bug Something isn't working untriaged labels Mar 5, 2024
@seraphjiang seraphjiang self-assigned this Mar 5, 2024
@seraphjiang seraphjiang added multiple datasource multiple datasource project and removed untriaged labels Mar 5, 2024
@ashwin-pc
Copy link
Member

@seraphjiang can you give some context as to why you opened this and why the name here differs from the one that @dagneyb proposed and the others aligned to? cc: @kgcreative

Original proposed names: #5790 (comment)

@seraphjiang
Copy link
Member Author

@seraphjiang can you give some context as to why you opened this and why the name here differs from the one that @dagneyb proposed and the others aligned to? cc: @kgcreative

Original proposed names: #5790 (comment)

Already provided context. We will only has one datasource introduced from 2.4

Please check my comment, 'connection' is not right term. However that discussion is to seek alignment for end user. We could get more input. Especially from end user, not developers.

This proposal is to disambiguous for developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project
Projects
Status: New
Development

No branches or pull requests

2 participants