Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Index patterns no longer alphabetized in the data source selector and filter causes CSP error #5609

Closed
adamdepollo opened this issue Dec 13, 2023 · 6 comments
Assignees
Labels
bug Something isn't working discover for discover reinvent v2.14.0

Comments

@adamdepollo
Copy link

Describe the bug

After upgrading to OpenSearch 2.11, the index pattern selection dropdown on the Discover dashboard no longer alphabetizes index patterns. This makes finding index patterns quite difficult.

Additionally, typing a pattern into the dropdown field does not seem to work correctly as a search function. I'm not sure what the expected functionality is here, but typing in a specific index pattern, for example, simplly changes the font display of that index pattern in the dropdown menu to bold. It does not actually search for that index or auto-select it from the list of dropdown options.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Discover
  2. Open the index pattern dropdown
  3. See patterns are not alphabetized

Expected behavior
Index patterns should be sorted alphabetically. Entering index pattern name in the dropdown text field should either auto-select the index pattern or filter the options in the dropdown to only those matching the query.

OpenSearch Version
2.11

Dashboards Version
2.11

Plugins

AWS managed OpenSearch. Using whatever the default plugins are.

Screenshots
Screenshot 2023-12-13 at 5 02 58 PM

Host/Environment (please complete the following information):

  • OS: Windows
  • Chrome Version 119.0.6045.200 (Official Build) (64-bit) and FireFox 120.0.1 64 bit

Additional context

Add any other context about the problem here.

@adamdepollo adamdepollo added bug Something isn't working untriaged labels Dec 13, 2023
@ashwin-pc
Copy link
Member

@mengweieric Can you take a look at this issue? cc: @anirudha

@mengweieric
Copy link
Collaborator

mengweieric commented Dec 15, 2023

@adamdepollo thanks for reporting this.

I checked out both 2.9 and 2.10, and the index patterns there are not sorted alphabetically started from 2.10 where new combo box based index selector was introduced where it does not sort options alphabetically by default but rather just render the list as it is.

2.9
Screenshot 2023-12-15 at 11 18 32 AM

Started from 2.10
Screenshot 2023-12-15 at 10 23 12 AM

We will introduce the sorting functionality to current index selector as soon as possible. Will create an issue and link to this issue.

With respect to filtering, I did a test on 2.11 and was able to see filtering working as expected.

Screen.Recording.2023-12-15.at.10.07.23.AM.mov

This is the PR addressing this on 2.11 could you check if this commit is included correctly? thanks!

@ashwin-pc ashwin-pc changed the title [BUG] Index patterns no longer alphabetized on discover page [BUG] Index patterns no longer alphabetized in the data source selector Dec 18, 2023
@adamdepollo
Copy link
Author

adamdepollo commented Dec 19, 2023

@mengweieric thanks for checking and confirming the sorting behavior. Not sure what's different between your environment and mine but I am definitely not seeing the same filtering behavior you showed.

Screen.Recording.2023-12-19.at.10.53.05.AM.mov

I do see this error in the console:
Screenshot 2023-12-19 at 11 01 18 AM

@ananzh ananzh added discover for discover reinvent v2.13.0 v2.12.0 and removed v2.13.0 labels Dec 21, 2023
@ashwin-pc ashwin-pc assigned mengweieric and unassigned ashwin-pc Jan 11, 2024
@wbeckler wbeckler changed the title [BUG] Index patterns no longer alphabetized in the data source selector [BUG] Index patterns no longer alphabetized in the data source selector and filter causes CSP error Jan 23, 2024
@ashwin-pc ashwin-pc added v2.13.0 and removed v2.12.0 labels Feb 7, 2024
@AMoo-Miki
Copy link
Collaborator

@mengweieric I noticed that #5719 added a changelog referencing this issue:

  1. Please raise a new PR to update the changelog to point to the original PR
  2. If this issue is related to the PR in question, please link them and close this.

@AMoo-Miki
Copy link
Collaborator

@ashwin-pc the PR addressing this was merged in to 2.12. Is there anything left that warrants labeling this for 2.13?

@ashwin-pc ashwin-pc added v2.14.0 and removed v2.13.0 labels Mar 19, 2024
@ananzh
Copy link
Member

ananzh commented Mar 29, 2024

@adamdepollo Have confirmed that this issue is resolved. Pls feel free to reopen it if you see other issues after the fix.

@ananzh ananzh closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discover for discover reinvent v2.14.0
Projects
None yet
Development

No branches or pull requests

5 participants