Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and remove more unused tutorials. #5446

Open
CMDWillYang opened this issue Nov 8, 2023 · 2 comments
Open

Investigate and remove more unused tutorials. #5446

CMDWillYang opened this issue Nov 8, 2023 · 2 comments
Assignees
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@CMDWillYang
Copy link
Contributor

pulled from issue #4448. PR #5212 did not remove the below tutorials since some are still accessed via routes and used (example). Please see the original issue and PR for more details and discussions.

  • src/plugins/home/public/application/components/tutorial.
@CMDWillYang CMDWillYang changed the title Research and remove more unused tutorials. Investigate and remove more unused tutorials. Nov 8, 2023
@AMoo-Miki AMoo-Miki added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. good first issue Good for newcomers and removed untriaged labels Nov 14, 2023
@ShatilKhan
Copy link
Contributor

ShatilKhan commented Nov 15, 2023

I can do this one
Please assign me @CMDWillYang

@ShatilKhan
Copy link
Contributor

ShatilKhan commented Dec 18, 2023

Some updates on the Issue
I found references for all the files inside src/plugins/home/public/application/components/tutorial

Now some of these files are interrelated , I assume we can't delete tutorial.js as it's being referenced in here:

import { Tutorial } from './tutorial/tutorial';

Here's the problem

number_parameter has been referenced in parameter_form:

import { NumberParameter } from './number_parameter';
import { StringParameter } from './string_parameter';

Then parameter_form is referenced in instruction_set but used only once:

Here's the usage :

render() {
let paramsForm;
if (this.props.params && this.state.isParamFormVisible) {
paramsForm = (
<ParameterForm
params={this.props.params}
paramValues={this.props.paramValues}
setParameter={this.props.setParameter}
/>
);
}

Then finally we have instruction_set referenced in tutorial which we can't delete due to it's reference mentioned at the begining:

import { InstructionSet } from './instruction_set';

My Understanding

So basically I can remove parameter_form reference from instruction_set and delete it since it's used once & then I can also delete number_parameter & string_parameter since they are not referenced anywhere else, hopefully that won't give any errors
@joshuarrrr Can you confirm if I can delete these or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

3 participants