Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Left side bar can not be expanded and collapsed #4780

Closed
abbyhu2000 opened this issue Aug 19, 2023 · 12 comments
Closed

[Data Explorer] Left side bar can not be expanded and collapsed #4780

abbyhu2000 opened this issue Aug 19, 2023 · 12 comments
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent enhancement New feature or request v2.12.0

Comments

@abbyhu2000
Copy link
Member

Previously, the legacy discover have the left side bar expanded by default, and it also provides option to collapse the side bar.

Discover 2.0 does not have the expanding and collapsing functionalities anymore.

@abbyhu2000 abbyhu2000 added bug Something isn't working discover for discover reinvent data explorer Issues related to the Data Explorer project labels Aug 19, 2023
@ashwin-pc ashwin-pc added enhancement New feature or request and removed bug Something isn't working labels Aug 24, 2023
@joshuarrrr
Copy link
Member

Because there's no PR open, relabeling for 2.12.

@ashwin-pc
Copy link
Member

ashwin-pc commented Oct 13, 2023

As Kevin mentioned in his comment here: #5260 (comment), lets use the resizable container component from OUI to implement this. This should happen in the data explorer plugin's layout between the canvas and the sidebar.

This is similar to the VisBuilder's implementation of the same care has to be taken to memoize the child components since resizing constantly rerenders the children unless memoized.

@LHozzan
Copy link

LHozzan commented Oct 25, 2023

This function is missing for me too or anybody with small screen.
Have you please some estimation to provide fix?

@joshuarrrr
Copy link
Member

@wbeckler This is labeled for 2.12, but do we need to actually get an assignee?

@Ganesh0107
Copy link
Contributor

@joshuarrrr @ashwin-pc I have a solution ready for this problem and would be happy to contribute. Could someone guide me on the next steps or whether you would like me to submit a pull request?

@ashwin-pc
Copy link
Member

@Ganesh0107 Thanks! yes any contributions here would be appreciated. The goal was to use OUI's resizeable containers to do this https://oui.opensearch.org/1.3/#/layout/resizable-container%23collapsible-resizable-panels. The change is needed in the Data Explorer component. You can raise a PR for the change and I can help you with any issues that you might face while implementing it :) Thanks for volunteering to help with this

@ananzh ananzh added v2.13.0 and removed v2.12.0 labels Dec 20, 2023
@CMDWillYang
Copy link
Contributor

thanks @ananzh and @ashwin-pc for suggesting this project for me, I would love to work on it!

@Ganesh0107 if you are still interested in tackling this lmk. would love to collaborate :)

@ananzh
Copy link
Member

ananzh commented Dec 20, 2023

@CMDWillYang I have assigned this to you.
@Ganesh0107, would like to hear your solution and have ur contribution. We have tag it to 2.13. Feel free to contact me or @CMDWillYang to cooperate.

@Ganesh0107
Copy link
Contributor

@CMDWillYang @ananzh I am about to raise PR in Couple of hours

@Ganesh0107
Copy link
Contributor

#5635

@ananzh
Copy link
Member

ananzh commented Jan 20, 2024

@Ganesh0107 thanks for opening the PR. I will remove @CMDWillYang and will start reviewing the PR.

@ananzh
Copy link
Member

ananzh commented Apr 23, 2024

Close it as resolved

@ananzh ananzh closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project discover for discover reinvent enhancement New feature or request v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants