Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #298

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Fix deprecation warnings #298

merged 8 commits into from
Jan 29, 2024

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Jan 22, 2024

Pull request

Couple of quick fixes to stop deprecation warnings spewing out when using scmdata.

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Changelog in '/changelog' added

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3b61470) 95.15% compared to head (8643ec3) 95.16%.
Report is 4 commits behind head on master.

❗ Current head 8643ec3 differs from pull request most recent head ea5bcb5. Consider uploading reports for the commit ea5bcb5 to get more accurate results

Files Patch % Lines
src/scmdata/run.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files          24       24           
  Lines        2190     2109   -81     
  Branches      404      379   -25     
=======================================
- Hits         2084     2007   -77     
+ Misses         86       85    -1     
+ Partials       20       17    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisjared
Copy link
Collaborator

Nice. Do we need to bump the minimum version of seaborn to what ever major release added the errorbar parameter?

@znicholls
Copy link
Collaborator Author

Do we need to bump the minimum version of seaborn to what ever major release added the errorbar parameter?

True, thanks

@znicholls znicholls merged commit de09428 into master Jan 29, 2024
14 checks passed
@znicholls znicholls deleted the future-warning-pd branch January 29, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants