Refactor apply_parallel #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 95.58% 95.15% -0.43%
==========================================
Files 24 24
Lines 2154 2190 +36
Branches 400 404 +4
==========================================
+ Hits 2059 2084 +25
- Misses 76 86 +10
- Partials 19 20 +1
☔ View full report in Codecov by Sentry. |
|
@lewisjared Python 3.8 seems happy even with these changes, I guess the future annotations work better than we though |
Co-authored-by: Mika Pflüger <mika.pflueger@climate-resource.com>
|
@lewisjared are you: a) happy with this |
lewisjared
approved these changes
Oct 16, 2023
|
Go for it |
Refactor apply parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Think of this branch as the 'dev' branch. I will make a couple of PRs into this and then we can merge the whole thing. The first commit (which is already here) just adds
from __future__ import annotationsand then runs ruff so that all the mess from that isn't in the other PRs as people review them.Please confirm that this pull request has done the following:
apply_parallelfunction to RunGroupBy #262Tests addedDocumentation added (where applicable)Example added (either to an existing notebook or as a new notebook, where applicable)