-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add py.typed file and resolve mypy errors in run.py #252
Conversation
@mikapfl Can you try using this branch today and see if there are any big problems |
I don't know if I will get to it today, but I'll do it ASAP. |
All good - no rush |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 95.68% 95.40% -0.29%
==========================================
Files 24 24
Lines 2132 2153 +21
Branches 395 400 +5
==========================================
+ Hits 2040 2054 +14
- Misses 73 79 +6
- Partials 19 20 +1
☔ View full report in Codecov by Sentry. |
I get lots and lots of errors, the root seems to be:
|
A lot better already; however, we still have a solid number of warnings in ndc-quantification:
I have a patch which reduces this somewhat, I'll post it as a PR to this PR. |
Merging this once the checks pass. The type-hints will be a source for continuous improvement |
Co-authored-by: Jared Lewis <jared@jared.kiwi.nz>
bea7bff
to
2b167fd
Compare
Description
Adds
py.typed
to the package to indicate to distribute type information.The type hints are not 100% complete with some additional work to be done in some of the modules, particularly
groupby.py
, but I think we have good coverage for the most commonly used parts of the library (namelyscmdata.ScmRun
).This PR ensures that
mypy src/scmdata/run.py
passes successfully with our current mypy config. These are quite relaxed compared to our new defaults thoughPull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
added