InstanceOfPatternMatch providing duplicate variable name

[mathewm3]

What version of OpenRewrite are you using?

I am using

• rewrite-maven-plugin 5.32.1
• rewrite-migrate-java 2.16.0

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

           <plugin>
                <groupId>org.openrewrite.maven</groupId>
                <artifactId>rewrite-maven-plugin</artifactId>
                <version>5.32.1</version>
                <configuration>
                    <activeRecipes>
                       <recipe>org.openrewrite.java.migrate.UpgradeToJava17</recipe>
                    </activeRecipes>
                </configuration>
                <dependencies>
                    <dependency>
                        <groupId>org.openrewrite.recipe</groupId>
                        <artifactId>rewrite-migrate-java</artifactId>
                        <version>2.16.0</version>
                    </dependency>
                </dependencies>
            </plugin>

What is the smallest, simplest way to reproduce the problem?

if (inputValue instanceof Number && upperBound instanceof Number && lowerBound instanceof Number) {

else if ((target instanceof String) && (token instanceof String))

What did you expect to see?

if (inputValue instanceof Number number1 && upperBound instanceof Number number2 && lowerBound instanceof Number number3) {


else if ((target instanceof String string1) && (token instanceof String string2))

What did you see instead?

if (inputValue instanceof Number number && upperBound instanceof Number number && lowerBound instanceof Number number) {

else if ((target instanceof String string) && (token instanceof String string))

What is the full stack trace of any errors you encountered?

No errors

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

Thanks for reporting @mathewm3 ! This is unfortunately a known issue, and I've tried in the past to get this resolved; see also

• InstanceOfPatternMatch leads to duplicate variable name in if statement with two different instanceof #174
• Duplicate variable name in if statement with two different instanceof #175

I hope you don't mind me closing this one as a duplicate. Any help towards getting the issue resolved would be welcome!