InstanceOfPatternMatch creates duplicate identifiers in same scope

[Bananeweizen]

What is the smallest, simplest way to reproduce the problem?

Add this to InstanceOfPatternMatchTest

        @Test
        void multipleCastsSameType() {
            rewriteRun(
              //language=java
              java(
                """
                  public class A {
                      void test(Object first, Object second) {
                          if (first instanceof String && second instanceof String) {
                              System.out.println((String) first);
                              System.out.println((String) second);
                          }
                      }
                  }
                  """,
                """
                  public class A {
                      void test(Object first, Object second) {
                          if (first instanceof String string1 && second instanceof String string2) {
                              System.out.println(string1);
                              System.out.println(string2);
                          }
                      }
                  }
                  """
              )
            );
        }

What did you see instead?

Both instanceof checks use the same identifier:

                  public class A {
                      void test(Object first, Object second) {
                          if (first instanceof String string && second instanceof String string) {
                              System.out.println(string);
                              System.out.println(string);
                          }
                      }
                  }

Are you interested in contributing a fix to OpenRewrite?

No, sorry.

[timtebeek]

Thanks for reporting this issue! We're already working on this in

• Duplicate variable name in if statement with two different instanceof #175

After seeing in reported before in

• InstanceOfPatternMatch leads to duplicate variable name in if statement with two different instanceof #174

Hope you don't mind me closing this issue as a duplicate; it's still appreciated, but best tracked in the existing issues.