Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalize function #255

Closed
CPernet opened this issue Jan 8, 2024 · 2 comments · Fixed by #262
Closed

externalize function #255

CPernet opened this issue Jan 8, 2024 · 2 comments · Fixed by #262
Assignees
@bendhouseart
Labels
enhancement New feature or request

Comments

@CPernet
Copy link
Contributor

CPernet commented Jan 8, 2024

check line 84 in https://github.com/openneuropet/PET2BIDS/edit/JOSS_paper/paper.md , needs to reference the python function
@CPernet
Copy link
Contributor Author

CPernet commented Jan 9, 2024

externalise update_json_with_dicom_value (l151+ from dcm2niix4pet.py) as a function update_jsonpet_with_dicom_value.py ?? adding pet to the name make it clear it is not just a maj it is pet specific (up to you which name to use)

@CPernet
Copy link
Contributor Author

CPernet commented Jan 15, 2024 •
edited
Loading

externalize https://github.com/openneuropet/PET2BIDS/blob/main/matlab/dcm2niix4pet.m#L320

@CPernet CPernet mentioned this issue Jan 15, 2024
Closed
39 tasks
@CPernet CPernet changed the title function name externalize function Jan 18, 2024
@bendhouseart bendhouseart mentioned this issue Jan 23, 2024
Merged
@bendhouseart bendhouseart added the enhancement New feature or request label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bendhouseart bendhouseart

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@CPernet @bendhouseart