Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting start position on mobile reset open overlays #3

Open
Ghoster981 opened this issue Feb 21, 2023 · 1 comment
Open

Selecting start position on mobile reset open overlays #3

Ghoster981 opened this issue Feb 21, 2023 · 1 comment
Assignees
@Ghoster981
Labels
BUG Something isn't working

Comments

@Ghoster981
Copy link
Contributor

Registrazione.schermo.2023-02-21.alle.10.32.05.mov
@stefanocudini stefanocudini added the BUG Something isn't working label Feb 21, 2023
@Ghoster981
Copy link
Contributor Author

This is caused by the componentWillUnmount method of base-map. Due to how React elements are structured the BaseMap will unmount for each page change on mobile. In my opinion fix it would require to move the map component up in the component tree but doing so require to split in two the top and bottom parts of mobile pages, actually making the code hard to read.

@Ghoster981 Ghoster981 transferred this issue from openmove/odh-mentor-otp Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ghoster981 Ghoster981

Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanocudini @Ghoster981