Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Docker CI/CD workflow trigger to only when there's new release #35

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

Giangblackk
Copy link
Contributor

I change Docker CI/CD workflow trigger from "on master" to "on new release" so this workflow creates new docker image only when new release created instead of when pull requests created.

Giangblackk and others added 11 commits May 27, 2023 13:26
and set fixed version of geospatial package in conda environment file
avoid create env before install
so Dockerfile is available for building image
- from master and pull request to tag only
- use github tag in docker image
and use conventional "on release" instead of "on tag" trigger
@Giangblackk
Copy link
Contributor Author

I also noticed that the built docker image seem to be unavailable for public use, I can't find it in package page of this repository.
While in my fork repository, I can see the built docker image in its package page without any login.

Should I create new issue for this problem?

@giswqs
Copy link
Member

giswqs commented Jan 18, 2024

Sorry for the delay!

@giswqs giswqs merged commit 972f3aa into opengeos:master Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants