Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile and Docker Build Image workflow #33

Merged
merged 8 commits into from
Jul 9, 2023

Conversation

Giangblackk
Copy link
Contributor

I added:

  • Dockerfile to build geospatial Docker image currently based on mambaorg/micromamba:1.4.2 docker image. The Dockerfile simply install geospatial metapackage.
  • docker-image.yml file from Github Action Docker Image build workflow

Why I did it:

  • I want to have a Docker image with every popular Python geospatial packages, so I can use it for my local development environment, instead of installing from conda everytime I start new project.

Proposal:

  • Using Github or Docker Hub to host built Docker image
  • dynamically configure built image version and base image version.

This is my first pull request, please give more advices so I can improve it.

@giswqs
Copy link
Member

giswqs commented Jul 7, 2023

Thank you for the PR. It looks good to me. I would suggest removing the version pin (0.8.0). In that way, we don't need to update those files when the package version is updated. Also, the geospatial package version pin is not very useful because it always install the latest version of its dependencies no matter it is geospatial v0.7.0 or v0.8.0.

@Giangblackk
Copy link
Contributor Author

Thank you for suggestion. I will update and notify you later.

Giangblackk and others added 2 commits July 8, 2023 17:59
so Dockerfile is available for building image
@giswqs giswqs changed the title Add Dockerfile and Docker Build Image workflow to build opengeos/geospatial Docker image Add Dockerfile and Docker Build Image workflow Jul 8, 2023
@giswqs
Copy link
Member

giswqs commented Jul 9, 2023

The Docker and Windows builds failed. I will fix it later.

@giswqs giswqs merged commit d445031 into opengeos:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants