Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StockLocation from ReturnAuthorization #12914

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 15, 2024

What? Why?

We have only one default location and don't need it associated to anything.

What should we test?

  • A return authorization can be created as before.
  • A return can be processed as before.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

We have only one default location and don't need it associated to
anything.
@mkllnk mkllnk self-assigned this Oct 15, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Oct 15, 2024
@mkllnk mkllnk marked this pull request as ready for review October 15, 2024 03:41
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@rioug rioug merged commit b461d49 into openfoodfoundation:master Oct 15, 2024
54 checks passed
@mkllnk mkllnk deleted the remove-stock-location-from-return-authorization branch October 16, 2024 00:07
@mkllnk
Copy link
Member Author

mkllnk commented Oct 16, 2024

Thanks for the quick merge, but there were testing steps on here! Well, I guess that return authorizations are so rarely used that we can probably live with the risk.

@rioug
Copy link
Collaborator

rioug commented Oct 16, 2024

Sorry, I missed that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants