Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the admin_style_v3 toggle from Production and Staging environments #12912

Conversation

chahmedejaz
Copy link
Collaborator

@chahmedejaz chahmedejaz commented Oct 15, 2024

What? Why?

What should we test?

  • As described in the issue

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

@chahmedejaz
Copy link
Collaborator Author

We can remove old bulk update specs now as we won't be using it anymore.

@chahmedejaz chahmedejaz force-pushed the task/12911-remove-admin-v3-toggle branch from 67a7ca1 to 32d7292 Compare October 15, 2024 11:23
@chahmedejaz chahmedejaz marked this pull request as ready for review October 15, 2024 11:37
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this would be straightforward or not..
I guess not! Thanks for working this out.

It's a bit complicated, but hopefully we can remove it again soon anyway.

@rioug
Copy link
Collaborator

rioug commented Oct 15, 2024

@chahmedejaz can you fix the conflict ?

@rioug rioug added the feature toggled These pull requests' changes are invisible by default and are grouped in release notes label Oct 15, 2024
@chahmedejaz chahmedejaz force-pushed the task/12911-remove-admin-v3-toggle branch from 32d7292 to c481623 Compare October 16, 2024 08:17
@chahmedejaz
Copy link
Collaborator Author

Thanks @dacook and @rioug - Conflicts have been resolved.

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good quick solution. I hope that we can remove the old code completely soon.

@drummer83 drummer83 self-assigned this Oct 19, 2024
@drummer83 drummer83 added pr-staged-au staging.openfoodnetwork.org.au and removed pr-staged-au staging.openfoodnetwork.org.au labels Oct 19, 2024
@drummer83
Copy link
Contributor

Looking good! Merging! Testing notes will follow...

@drummer83 drummer83 merged commit c3b5456 into openfoodfoundation:master Oct 19, 2024
53 checks passed
@drummer83
Copy link
Contributor

Hi @chahmedejaz,
Thanks for working on this. Here are my testing notes now.

Before staging

  • Feature toggle before staging:
    ksnip_20241019-132133

  • Page products_old can be loaded:
    ksnip_20241019-132235

After staging

  • Feature toggle after staging:
    ksnip_20241019-133347

  • Page product_old cannot be loaded anymore.

  • I couldn't find any broken links linking to the product_old page.

  • I did not test anything regarding the toggle in the development environment, because I think it's not critical.

Thanks again! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature toggled These pull requests' changes are invisible by default and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove the admin_style_v3 toggle from production and staging environments
5 participants