Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail gracefully on DFC product import errors #12906

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fail gracefully on DFC product import errors #12906

merged 2 commits into from
Oct 11, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 11, 2024

What? Why?

What should we test?

  • Visit Admin Product Import.
  • Enter a bogus URL or somewhere you don't have access to as catalog URL.
  • Try to import catalog.
  • You should see an error message.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the user facing changes Thes pull requests affect the user experience label Oct 11, 2024
@mkllnk mkllnk self-assigned this Oct 11, 2024
@mkllnk mkllnk marked this pull request as ready for review October 11, 2024 02:13
@mkllnk mkllnk added the pr-staged-uk staging.openfoodnetwork.org.uk label Oct 11, 2024
@mkllnk mkllnk merged commit 52c1491 into openfoodfoundation:master Oct 11, 2024
56 checks passed
@mkllnk mkllnk deleted the dfc-stock-import branch October 11, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkllnk mkllnk

Labels
pr-staged-uk staging.openfoodnetwork.org.uk user facing changes Thes pull requests affect the user experience
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error handling on DFC Product Import
1 participant
@mkllnk