Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded StockLocation code #12887

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 2, 2024

What? Why?

Another little round of cleanup. We don't actually need stock locations but cleaning them up is a bit more work. I just did some obvious little steps while working on similar code.

What should we test?

  • Stock is displayed correctly in the shop.
  • A return authorization can be created as before.
  • A new variant can be created and it has stock.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Oct 2, 2024
@mkllnk mkllnk self-assigned this Oct 2, 2024
@mkllnk mkllnk marked this pull request as ready for review October 2, 2024 22:47
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🧹

@rioug rioug merged commit e5b7f89 into openfoodfoundation:master Oct 6, 2024
54 checks passed
@mkllnk mkllnk deleted the stock-cleanup2 branch October 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants