Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database index to order cycle dates #12884

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 2, 2024

What? Why?

We had the hope that index order cycle dates would improve performance of certain queries but I couldn't find any improvement. Anyway, to save others from trying this again, I still added the indexes. They don't seem to have a downside either.

What should we test?

  • I think specs are enough.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Oct 2, 2024
@mkllnk mkllnk self-assigned this Oct 2, 2024
@mkllnk mkllnk marked this pull request as ready for review October 2, 2024 04:41
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rioug rioug merged commit 6eb5986 into openfoodfoundation:master Oct 2, 2024
54 checks passed
@mkllnk mkllnk deleted the oc-index branch October 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants