Reproduces bug #12835 #12841
Merged
Reproduces bug #12835 #12841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
added
the
technical changes only
dacook
reviewed
Sep 4, 2024
Comment on lines
442
to
443
| rows = find("table.report__table").all("thead tr") | ||
| table = rows.map { |r| r.all("th").map { |c| c.text.strip } } |
There was a problem hiding this comment.
This will be in a helper method on your other PR. We can rebase on that branch to include it, but for now I'll focus on the actual bug...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Regression specs for #12835.
This is done both in a system and in a unit spec. I'm not 100% sure about the unit spec. I'm not very proficient at these yet.
The specs are not optimized. I think there could be some things to improve, like setting the distributor and supplier test cases as shared examples, and visiting the report page straight on, without clicking around (this is meant for the system spec, of course).
Still, the main goal here is to reproduce the S2 bug #12835, and this is achieved, and is perhaps helpful to for the dev picking this up.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates