[admin] Update page titles #12833
Merged
[admin] Update page titles #12833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacook
added
the
user facing changes
This is much more meaningful than the controller name, and is helpful for browser tab history.
Because the page title has extra content.
filipefurtad0
force-pushed
the
page-titles
branch
from
46ef590
to
be4e0a2
Compare
filipefurtad0
added
pr-staged-fr
|
Hey @dacook, I've smoke tested the page titles by checking that these reflect the current page. Also test page titles reflect the current locale. Some examples below:
Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
It struck me today that the browser tab title/history doesn't include the full name of the page you're on. For example, if I had edited multiple products and wanted to go back to a particular one, I can't choose it. They are all simply labelled "Products".
So I wondered if we can easily use the titles that appear on the page. At first glance it looks much more helpful to me:
Although note that there are some differences. Sometimes the page title doesn't match the navigation menu. For example:
Some deeper pages have arrows, so these are stripped:
What should we test?
Click around and check the page titles in the browser tab, and in browser history.
Try another language too.
One page was changed that I didn't know how to test: