Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes test on PDF file on sales tax report #12830

Conversation

filipefurtad0
Copy link
Contributor

What? Why?

Closes #12829.

Addresses the consistently failing spec which was first spotted in this PR (locally) and appeared here, on the build.

Does not fix it. Removes the test on downloading PDF files as discussed here.

What should we test?

  • green build

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Aug 29, 2024
@filipefurtad0 filipefurtad0 self-assigned this Aug 29, 2024
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dacook dacook merged commit f9a7634 into openfoodfoundation:master Sep 2, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Flaky] PDF file download - './spec/system/admin/reports/sales_tax/sales_tax_totals_by_order_spec.rb
3 participants