Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact path for simplecov report upload #12822

Merged

Conversation

johansenja
Copy link
Contributor

What? Why?

Resolves issue in comment here: #12798 (review); only files in the root of the coverage directory were being uploaded, not nested files

What should we test?

  • Go to the assets after the CI run
  • Download the report
    • The directory should now contain the assets folder
  • Open index.html
    • the page should now be properly styled

Release notes

  • Technical changes only

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@johansenja
Copy link
Contributor Author

Much better than the old one!
Screenshot 2024-08-28 at 11 26 15

Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That works well.

I was worried about using space for something that's not important but the zip size is only increased by 120kb (from 862kb to 980kb). I think it's worth it.

@mkllnk mkllnk merged commit b2e15f5 into openfoodfoundation:master Aug 28, 2024
52 checks passed
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants