Adds retry option to flaky edit_spec.rb #12800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipefurtad0
added
the
technical changes only
filipefurtad0
changed the title
filipefurtad0
force-pushed
the
adds_retry_option_on_edit_spec
branch
from
4d3f9ce
to
ddd3bc1
Compare
...does so on another flaky test case
filipefurtad0
force-pushed
the
adds_retry_option_on_edit_spec
branch
from
0021bd2
to
32cd14e
Compare
mkllnk
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Thank you for looking into this. The message is displayed from an AngularJS controller. So part of solving this problem may be replacing that code. I think that those sleeps may actually help. It may be that the Save button was clicked before AngularJS had initialised all triggers and then the saving the happen.
Thanks @wandji20 for your suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Can't reproduce it locally (even after running it 50 times with out test script) and adding a sleep also does not seem to help: Pragmatically adding a
retry: 3flag, as this is occurring quite often apparently.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates