Clearer error message and clean up for Product Categories

[EdwardLi-coder]

What? Why?

• Closes [Product Categories] Clearer error message and clean up #12773

I found that the code had no place to use spree_classification_primary_taxon_error and invalid_taxonomy_id, so I deleted them

What should we test?

As described in the issue:

• Admin setting page should work properly with new taxons options
• All crud actions should be available in admin settings for taxons

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[mkllnk]

Thank you for tackling this. Could you reduce your change to only en.yml? The other files will get updated automatically in our release process. It will be easier to see your actual changes then as well.

[mkllnk]

We never change other locales than en.yml because they are updated automatically through our Transifex integration.

[EdwardLi-coder]

We never change other locales than en.yml because they are updated automatically through our Transifex integration.

OK.I will update it.

[mkllnk]

Great, thank you!

Note that we usually don't merge master but rebase on master if needed. You don't have to do that for this pull request though.

[chahmedejaz]

Looks good, thanks. However as per the issue, can you please also confirm if spree.new_taxon translation is being used?

[EdwardLi-coder]

Great, thank you!

Note that we usually don't merge master but rebase on master if needed. You don't have to do that for this pull request though.

Ok,I see.Thank you tell me.

[EdwardLi-coder]

Looks good, thanks. However as per the issue, can you please also confirm if spree.new_taxon translation is being used?

Maybe this use it.I'm not sure.
%li = button_link_to t(".new_taxon"), spree.new_admin_taxon_url, icon: 'icon-plus', id: 'admin_new_taxon_link'

[chahmedejaz]

%li = button_link_to t(".new_taxon"), spree.new_admin_taxon_url, icon: 'icon-plus', id: 'admin_new_taxon_link'

I think the following translation is being used here because it's using Rail's lazy translation lookup and it should get translated to this key based upon the file path in which it's used, spree.admin.taxons.index.new_taxon:

openfoodnetwork/config/locales/en.yml

Line 4587 in 9170799

new_taxon: 'New product category'

I think we should validate this and remove spree.new_taxon as well if it's unused. Would be good to please do that? Thanks.

[EdwardLi-coder]

%li = button_link_to t(".new_taxon"), spree.new_admin_taxon_url, icon: 'icon-plus', id: 'admin_new_taxon_link'

I think the following translation is being used here because it's using Rail's lazy translation lookup and it should get translated to this key based upon the file path in which it's used, spree.admin.taxons.index.new_taxon:

openfoodnetwork/config/locales/en.yml

Line 4587 in 9170799

new_taxon: 'New product category'

I think we should validate this and remove spree.new_taxon as well if it's unused. Would be good to please do that? Thanks.

I have already deleted spree.new_taxon.Thanks

[chahmedejaz]

%li = button_link_to t(".new_taxon"), spree.new_admin_taxon_url, icon: 'icon-plus', id: 'admin_new_taxon_link'

I think the following translation is being used here because it's using Rail's lazy translation lookup and it should get translated to this key based upon the file path in which it's used, spree.admin.taxons.index.new_taxon:

openfoodnetwork/config/locales/en.yml

Line 4587 in 9170799

new_taxon: 'New product category'

I think we should validate this and remove spree.new_taxon as well if it's unused. Would be good to please do that? Thanks.

I have already deleted spree.new_taxon.Thanks

Really sorry, but I believe you have pushed that change in another branch which might not be relevant to that change.
https://github.com/EdwardLi-coder/openfoodnetwork/tree/change_colour_of_complete_order

Can you please validate and push that change in this branch so that the relevant issue's changes are within their respective branches?

[EdwardLi-coder]

%li = button_link_to t(".new_taxon"), spree.new_admin_taxon_url, icon: 'icon-plus', id: 'admin_new_taxon_link'

I think the following translation is being used here because it's using Rail's lazy translation lookup and it should get translated to this key based upon the file path in which it's used, spree.admin.taxons.index.new_taxon:

openfoodnetwork/config/locales/en.yml

Line 4587 in 9170799

new_taxon: 'New product category'

I think we should validate this and remove spree.new_taxon as well if it's unused. Would be good to please do that? Thanks.

I have already deleted spree.new_taxon.Thanks

Really sorry, but I believe you have pushed that change in another branch which might not be relevant to that change. https://github.com/EdwardLi-coder/openfoodnetwork/tree/change_colour_of_complete_order

Can you please validate and push that change in this branch so that the relevant issue's changes are within their respective branches?

Thank you for bringing this to my attention. I apologize for the confusion earlier. I have now verified and corrected the issue.

[chahmedejaz]

No worries @EdwardLi-coder, all good now. Thanks♥️

[drummer83]

Hi @EdwardLi-coder,
Thank you for finishing this up! 💪

I have tested the product categories and couldn't find any problems.

Also the new error message is shown:

Excellent! Merging! 🎉
Thanks again!

[EdwardLi-coder]

Hi @EdwardLi-coder,

Thank you for finishing this up! 💪

I have tested the product categories and couldn't find any problems.

Also the new error message is shown:

Excellent! Merging! 🎉

Thanks again!

Ok.I'm glad my code can merge.Thanks