Remove awesome nested set gem and dependencies [OFN-11636]

[wandji20]

What? Why?

• Closes Remove gem awesome_nested_set #11636
• Closes Errors when deleting (and creating?) taxonomies #6033
• Closes Super admin: Renaming the header taxon not working when right clicking and selecting 'edit' #9385
• Closes Super admin: Changing the order of taxons is not working #9386
• Closes Super admin: Deleting the last taxon or header taxon using right click 'remove' does not work #9387
• Closes Remove jquery.jstree from the taxonomy page #9677

Awesomenested set and related dependencies where removed

• Taxonomy model (deleted)
• Attributes: parent_id, lft, and rgt where removed from Taxon model
• Taxonomy controller (including API/V0) and specs deleted
• Taxon controller ((including API/V0) and specs updated to reflect model change and all CRUD actions added
• Taxons replaced Taxonomies in admin setting page

What should we test?

• Admin setting page should work properly with new taxons options
• Taxnonomies should be removed from admin settings page
• All crud actions should be available in adminnn settings for taxons

Video

Screencast.from.07-08-2024.15.48.29.webm

• Visit ... page.
  http://localhost:3000/admin/general_settings/edit

Release notes

Removes unused tree structure on product categories. Your taxons and taxonomies will now be listed in one flat alphabetical list.

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0)
• Technical changes only

Dependencies

N/A

Documentation updates

N/A

[mkllnk]

Excellent work! Thank you.

It would have been easier to review if you had created several smaller commits to guide us through the changes step by step.

I'm adding one commit to fix up the migration but otherwise it's all good. There's one leftover jquery plugin now that we can remove as well. Would you like to tackle that?

[mkllnk]

It looks like a typo here:

Suggested change

	remove_reference :spree_taxons, :parent, index: true, foriegn_key: true
	remove_reference :spree_taxons, :taxonomy, index: true, foriegn_key: true
	remove_reference :spree_taxons, :parent, index: true, foreign_key: true
	remove_reference :spree_taxons, :taxonomy, index: true, foreign_key: true

So I assume that you didn't test rolling back the migration and check that it reverts back to how it was.

[mkllnk]

I'll add a commit to make the migration reversible.

[mkllnk]

What about the Javascript part?

vendor/assets/javascripts/jquery.jstree/jquery.jstree.js

[mkllnk]

Oh, and it looks like you need to rebase this pull request on the latest master to resolve conflicts.

[mkllnk]

While testing I noticed that the permalink is not visible. Setting a new value doesn't work either. I don't actually think that it's used anywhere. Can you remove at least the input field from the form?

[rioug]

Awesome, thanks ! 🙏
I'll second Maikel here, it would have been easier to follow if it was split in multiple small commit.
I think we'll need to flag this to the instance manager when it get released, they might want to review their taxonomy afterward.

[drummer83]

Hi @wandji20,
Thank you for yet another PR! 💪
I have tested it on our servers.

Configuration tabs in the instance settings

Before:

After:

Taxonomies vs. Product Categories page

Before:

After:

Taxonomy edit vs. Product Category edit page

Before:

After:

Header taxonomies and sub taxons listed as Product Categories

After:

Additional test cases

• New page 'Product Categories'. ✔️
• Old page 'Taxonomies' is gone. ✔️
• All previous header taxonomies are listed as product categories now. ✔️
• All previous taxons and sub taxons are listed as product categories. ✔️
• Create new product category. ✔️
• Edit product category. ✔️
• Can't delete a product category with assigned products. ✔️
  
• Can delete a product category without assigned products. ✔️
• Product categories are listed in an alphabetical order. ✔️
• Permalink has been removed. ✔️

Open (nice to have in a follow-up)

• Improve error message (spree.admin.taxons.destroy.delete_taxon.error): Unable to delete the product category due to assigned products. ❓
• Is the key spree_classification_primary_taxon_error still used anywhere? ❓
• Is the key spree.new_taxon still used anywhere? ❓
• Is the key spree.api.invalid_taxonomy_id still used anywhere? ❓

Task

❗ Inform instance managers about this change.

Conclusion

Everything I tested is working well. Great job!
I only have minor questions, which can be addressed in a follow up, if at all.

This PR is ready to go. Merging! 🚀
Thanks! 🎉

[drummer83]

Created #12773 for follow up issues.