(Fix) chore(deps): bump wicked_pdf from 2.6.3 to 2.8.0 [OFN-12214]

[wandji20]

What? Why?

• Closes chore(deps): bump wicked_pdf from 2.6.3 to 2.8.0 #12214

Remove webpack compiled CSS from order pdf files

What should we test?

Generated order pdf from (print order) should work and look the same as before

• Visit ... page.
  http://localhost:3000/admin/orders/

Release notes

(Fix) chore(deps): bump wicked_pdf from 2.6.3 to 2.8.0 [OFN-12214]

(Fix) chore(deps): bump wicked_pdf from 2.6.3 to 2.8.0

Dependencies

wicked-pdf

Documentation updates

N/A

[rioug]

Removing the stylesheet from the pdf results in order looking differently (before on the right):

[wandji20]

Thanks @rioug for reviewing
Did you test this in production or locally?

[rioug]

Did you test this in production or locally?

locally

[wandji20]

This should happen locally since wicked_pdf handles assets differently in development and production mode.
Working on this one, I did the following to ensure the gem will try and read assets like in production

• Unpack the gem with gem unpack wicked_pdf and adjust the code to mimic a production environment
• Precompiled assets

Then I noticed the mail.scss was not found in wicked_pdf asset finder method.
If we choose to move the mail-related styles to app/assets/stylesheets and precompile the new mail.scss
Then the asset will be found by wicked_pdf asset finder .

Can you please checkout this conversation I had with Maikel

[rioug]

Can you please checkout this conversation I had with Maikel

I had missed that sorry!
I just tested the PR on staging and I get the same result :

If we choose to move the mail-related styles to app/assets/stylesheets and precompile the new mail.scss
Then the asset will be found by wicked_pdf asset finder .

It looks like we'll need to do this, do you want to have a go at it ?

[rioug]

@wandji20 There is a a failing spec, could you have a look at it ?

[wandji20]

I am not so positive this is a good change.
So, I noticed a strange output in extracted text from pdf.
This is caused due to multi-line table header values.
Sadly, I could not figure out why it works when the mail.scss is compiled with Webpacker (before changes).

For an invoice with a header (see screenshot)

I get this

Seems to me it reads the header as two lines instead of one due to the longer header values spanning two lines

[mkllnk]

This can happen in the conversion to text. It's very unfortunate but I don't think it can be easily solved. So we have to work with it for now.

[mkllnk]

This can happen in the conversion to text. It's very unfortunate but I don't think it can be easily solved. So we have to work with it for now.

[rioug]

Looks good 👍

[drummer83]

Notes to self for testing:

• invoices feature toggle on/off
• individual vs. bulk printing
• standard vs. alternative template
• sending vs. printing invoice
• legacy vs. admin style v3

[RachL]

@drummer83 BUU is about to be displayed to 75% of the users. And also dev and testers environment are displayed by default on admin style v3.
I think we can stop testing legacy version from now on 👍

For invoice feature, I don't know when we will have budget to move forward, so you can also only focus on invoice with toggle OFF.

[drummer83]

Hi @wandji20,
Thanks for working on this one!

Here are my testing notes:

Page	Invoice Template	Action	Result
Order list (bulk)	Standard	Print invoice	✔️
Order list (bulk)	Standard	Send invoice	✔️
Edit order	Standard	Print invoice	✔️
Edit order	Standard	Send invoice	✔️
Order list (bulk)	Alternative	Print invoice	✔️
Order list (bulk)	Alternative	Send invoice	✔️
Edit order	Alternative	Print invoice	✔️
Edit order	Alternative	Send invoice	✔️

The invoices are sent and printed correctly, the corresponding layout is applied. ✔️

I came across some other issues while testing, but those are not related to this PR.
#12802
#12803

This one is ready to go! Great work! 🎉
Thanks again! Merging! 🚀