Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace text angular editor with trix editor in About Us and Shopfront message fields #12734
Replace text angular editor with trix editor in About Us and Shopfront message fields #12734
Changes from 8 commits
a6d3909
2d6ffc0
7961ff7
70ca031
429e2b0
a2c3ac2
b174080
ae2e92f
08ab405
63c62ca
a745249
9895116
dd51755
60afa4d
f474afa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trix.config.lang[key] = translation;
only seems to work in Firefox for some reason. The translations have to be set more manually for Chrome.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting, and unfortunate because you have map quite a lot data.
According to this wiki, it suggests overwriting the
lang
config in one command.But you tried that and it didn't work, so it would be worth raising an issue.
I had a look for issues and could only find one.
The final comment shows another method using
Object.assign
. I don't know if that would make a different, but perhaps it's worth trying.basecamp/trix#874 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find, fixed by 63c62ca and it works in Firefox and Chrome.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevents horizontal scrollber on Trix button toolbar in smaller screens.
This file was deleted.