Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unneeded FDC compatibility code from product import #12729

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Aug 2, 2024

What? Why?

The FDC project didn't quite comply with the DFC standard in the past but now it does. So we can remove the compatibility code again.

What should we test?

  • Log in with DFC user.
  • Import products from https://env-0105831.jcloud-ver-jpe.ik-server.com/api/dfc/Enterprises/test-hodmedod/SuppliedProducts.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Aug 2, 2024
@mkllnk mkllnk self-assigned this Aug 2, 2024
@mkllnk mkllnk marked this pull request as ready for review August 7, 2024 05:23
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🧹

@rioug rioug self-requested a review August 12, 2024 01:10
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@rioug rioug merged commit 1f55ff4 into openfoodfoundation:master Aug 12, 2024
50 checks passed
@mkllnk mkllnk deleted the fdc-update branch August 22, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants