Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) chore(deps): bump invisible_captcha from 2.2.0 to 2.3.0 #12725

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

wandji20
Copy link
Contributor

@wandji20 wandji20 commented Aug 1, 2024

Bumps invisible_captcha from 2.2.0 to 2.3.0.

updated-dependencies:

  • dependency-name: invisible_captcha dependency-type: direct:production update-type: version-update:semver-minor

What? Why?

Bump invisible_recaptcha to 2.3.0 and disable spinner validation in test mode.

What should we test?

  • User sign up process should be the same as before

Release notes

Bumps invisible_captcha from 2.2.0 to 2.3.0.

Changelog Category (reviewers may add a label for the release notes):

  • Technical changes only

Dependencies

N/A

Documentation updates

N/A

Bumps [invisible_captcha](https://github.com/markets/invisible_captcha) from 2.2.0 to 2.3.0.
- [Changelog](https://github.com/markets/invisible_captcha/blob/master/CHANGELOG.md)
- [Commits](markets/invisible_captcha@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: invisible_captcha
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@wandji20 wandji20 marked this pull request as draft August 1, 2024 16:40
@wandji20 wandji20 marked this pull request as ready for review August 1, 2024 20:52
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! That's the quickest solution.

The Readme contains an alternative that would need an update to every request spec. That's not nice to maintain. So hopefully we can rely on the gem to do its job without us testing it.

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wandji20 !

@drummer83 drummer83 self-assigned this Aug 6, 2024
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Aug 6, 2024
@drummer83
Copy link
Contributor

Thanks @wandji20,

I can confirm that the sign-up process seems to work as before. 👍

Merging! 🎉

@drummer83 drummer83 merged commit 256d5ba into openfoodfoundation:master Aug 6, 2024
54 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants