Preload enterprise logos and promo images for /shops page #12723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
When visiting https://openfoodnetwork.org.uk/shops, the page load is very slow. Given that this page is linked to from the
CTA above the fold on https://openfoodnetwork.org.uk, it seems ideal that should load quickly.
One of the low-hanging fruits here is to make sure that each of the enterprise's
logo
andpromo_image
is preloaded, to avoidn+2
queries:It's not the most significant performance increase (though I have a few other ones too) - especially when there is caching - but it feels like a sensible thing to do
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
Dependencies
I have some other low-hanging fruit optimisations that I might propose here too (which might also be more significant) but they should be distinct enough to be separate follow-ons
Documentation updates
N/A