Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spec #12684

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix flaky spec #12684

merged 1 commit into from
Jul 22, 2024

Conversation

dacook
Copy link
Member

@dacook dacook commented Jul 18, 2024

This spec was getting flaky because:

expected not to find text "20"
in "Logged in as : olen@harveydenesik.biz Account Logout ... Weight (g) YES 1g On demand Enterprise 203 Enterprise 203 ...

What should we test?

green specs.

@dacook dacook added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Jul 18, 2024
@dacook dacook self-assigned this Jul 18, 2024
Copy link
Collaborator

@chahmedejaz chahmedejaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This spec was getting flaky because:

> expected not to find text "20"
> in "Logged in as : olen@harveydenesik.biz Account Logout ... Weight (g) YES 1g On demand Enterprise 203 Enterprise 203
@rioug rioug merged commit 5caeb16 into openfoodfoundation:master Jul 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants