Ensure product category error message is shown when creating new product [OFN-12591]

[wandji20]

What? Why?

• Closes Error 500 when product category left blank #12591
  For validations to run on a product variant when creating a product, I changed the ensure_standard_variant to run after validations have run and updated the error messages.

What should we test?

Creating a product without a category will display the proper error message
Creating a product without a producer will display the proper error message

• http://localhost:3000/admin/products/new

Release notes

Add an error message when creating a new product without a product category or without producer

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• Technical changes only

The title of the pull request will be included in the release notes.

Add an error message when creating a new product without a product category

Dependencies

[dacook]

Looks good to me, apart from one query for Gaetan. Thank you!

[rioug]

Good effort ! I think it needs a few tweaks to clean it up, see comments below. We are also missing a spec for creating a product without a producer (supplier), could you add that?

Thanks !

[rioug]

Thanks for the quick turn around. There are still a couple things to iron out see my comments. Sorry about the translations, I somehow missed it was still used 🙏

[rioug]

Looks good now, Thanks 🙏

[filipefurtad0]

Hey @wandji20 ,
I see there are conflicts on the .rubocop_todo.yml file. Are you able to fix these?

Moving to In progress, for the time being.

[wandji20]

Hey @wandji20 , I see there are conflicts on the .rubocop_todo.yml file. Are you able to fix these?

Moving to In progress, for the time being.

For this, I rebased and regenerated .rubocop_todo.yml with bundle exec rubocop --regenerate-todo --no-auto-gen-timestamp

[drummer83]

Hi @wandji20,
Thank you for yet another PR! Before staging I also couldn't reproduce the error 500 but found that products could be created without variants - just like you mentioned.

I tested this in detail while I was working on it anyway, so you will thing below, which are out of scope for this PR, but I found it worth mentioning for completeness.

Comparison before and after staging the PR

Field	Before	After
Supplier	No error when empty ❌	❗ Error when empty ✔️ 💪
	Product can be created when empty, but no variant created ❌	❗ Product can't be created ✔️ 💪
	No red highlighting at all on error ❌	No red color of field's label on error ❌
Product name	Error when empty ✔️	Error when empty ✔️
Unit size	Error when empty ✔️	Error when empty ✔️
	No red border on error ❌	No red border on error ❌
Value (if variant unit == item)	No error when empty (set to '1') ✔️	No error when empty (set to '1') ✔️
Unit name (if variant unit == item)	Error when empty ✔️	Error when empty ✔️
	Unit name is not kept after error messages ❌	Unit name is not kept after error messages ❌
	No red highlighting at all on error ❌	No red highlighting at all on error ❌
Value (if variant unit != item)	Error when not a number ✔️	Error when not a number ✔️
	No red border on error ❌	No red border on error ❌
Display as (if variant unit != item)	No error when empty ✔️	No error when empty ✔️
Product category	No error when empty ❌	❗ Error when empty ✔️ 💪
	Product can be created when empty, but no variant created ❌	❗ Product can't be created ✔️ 💪
	No red highlighting at all on error ❌	No red border on error ❌
Price	Error when not a number ✔️	Error when not a number ✔️
Unit price	Auto-filled ✔️	Auto-filled ✔️
Tax category	Pre-selected ✔️	Pre-selected ✔️
Shipping category	Pre-selected ✔️	Pre-selected ✔️
	Shipping category is not kept after error message ❌	Shipping category is not kept after error message ❌
On hand	No error when empty (set to 0) ✔️	No error when empty (set to 0) ✔️
On demand	Checkbox only ✔️	Checkbox only ✔️
Image	No error when empty ✔️	No error when empty ✔️

Further ideas for improvement

• Use same 'can't be blank' string for supplier and product category as for e.g. product name.
• Unify the three different types of drop down menus:
  • Modern design wth pre-filled 'Select a supplier'
  • Modern design without pre-filled information (completely empty)
  • Legacy design (smaller line heights, no highlighting on hover)

General remark

• Unit value (if variant unit == item) can only be edited on /products, not on the /edit page.

Conclusion

The issue in #12591 is resolved. 💪
There was no regression found within this PR. 🥳
Anything else I found was out of scope of this PR.
We can merge and address the other bits in separate PRs. 🪨

Thanks again for your work!

[drummer83]

@wandji20 I've created #12744 just in case you would like to tackle some of those. No need to address them all at once.
Thanks again!

[wandji20]

Sure @drummer83
That is fine by me