-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure product category error message is shown when creating new product [OFN-12591] #12671
Conversation
c8956d7
to
4f5bce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from one query for Gaetan. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good effort ! I think it needs a few tweaks to clean it up, see comments below. We are also missing a spec for creating a product without a producer (supplier), could you add that?
Thanks !
11d66d7
to
4f0130e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turn around. There are still a couple things to iron out see my comments. Sorry about the translations, I somehow missed it was still used 🙏
75e095e
to
3be0502
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, Thanks 🙏
Hey @wandji20 , Moving to In progress, for the time being. |
…from product create action [OFN-12591]
For this, I rebased and regenerated |
Hi @wandji20, I tested this in detail while I was working on it anyway, so you will thing below, which are out of scope for this PR, but I found it worth mentioning for completeness. Comparison before and after staging the PR
Further ideas for improvement
General remark
ConclusionThe issue in #12591 is resolved. 💪 Thanks again for your work! |
Sure @drummer83 |
What? Why?
For validations to run on a product variant when creating a product, I changed the
ensure_standard_variant
to run after validations have run and updated the error messages.What should we test?
Creating a product without a category will display the proper error message
Creating a product without a producer will display the proper error message
Release notes
Add an error message when creating a new product without a product category or without producer
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Add an error message when creating a new product without a product category
Dependencies