-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SR from clear search button [OFN-12551] #12664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great 🎉 Good to see Reflex being removed from the Products page finally! Thanks 🙌
Right now we don't have a spec to validate this Clear Search button click functionality, are you willing to add one please? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thanks 🙌
Hi @wandji20 - Sorry I missed it before in review, we needed to replace Reflex action with Turbo as well. I've pushed that respective change. |
Thanks @chahmedejaz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍 thanks 🙏
Hi @wandji20, I have verified that the user experience is the same before and after your PR. Here are the screenshots. I have noticed an error in the browser console. However this is shown at page load already and it's indepent from the 'Clear search' button. It's shown in current master as well. ConclusionNo issues found, all good. 👍 |
What? Why?
Remove Stimulus Reflex from the clear search button and delete unused products reflex class
What should we test?
Check that products clear search button is handled by turbo
http://localhost:3000/admin/products
Release notes
Changelog Category (reviewers may add a label for the release notes):
Remove SR from clear search button
Dependencies