Remove SR from clear search button [OFN-12551] #12664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chahmedejaz
requested changes
Jul 16, 2024
|
Hi @wandji20 - Sorry I missed it before in review, we needed to replace Reflex action with Turbo as well. I've pushed that respective change. |
|
Thanks @chahmedejaz |
rioug
added
the
user facing changes
rioug
approved these changes
Jul 22, 2024
rioug
added
technical changes only
drummer83
added
pr-staged-au
|
Hi @wandji20, I have verified that the user experience is the same before and after your PR. Here are the screenshots. Before: After: I have noticed an error in the browser console. However this is shown at page load already and it's indepent from the 'Clear search' button. It's shown in current master as well. ConclusionNo issues found, all good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Remove Stimulus Reflex from the clear search button and delete unused products reflex class
What should we test?
Check that products clear search button is handled by turbo
http://localhost:3000/admin/products
Release notes
Changelog Category (reviewers may add a label for the release notes):
Remove SR from clear search button
Dependencies