(Fix) [User->New] Language is displayed twice [OFN-11513]

[wandji20]

What? Why?

• Closes [User->New] Language is displayed twice #11513

Change admin new user local dropdown to use config locale options

What should we test?

Test that admin new user local dropdown will render correct locales

• Visit ... page.
  http://localhost:3000/admin/users/new

Release notes

(Fix) [User->New] Language is displayed twice

Changelog Category (reviewers may add a label for the release notes):

• User facing changes

The title of the pull request will be included in the release notes.
(Fix) [User->New] Language is displayed twice

Dependencies

[rioug]

Hi @wandji20 , this doesn't really fix the root cause of the issue, I think we actually need to fix the duplication.

[rioug]

I think we are better off fixing the issue here :

openfoodnetwork/lib/open_food_network/i18n_config.rb

Line 19 in 0c43dd4

def self.available_locales

The helper function itself isn't wrong (

openfoodnetwork/app/helpers/i18n_helper.rb

Line 4 in 0c43dd4

def locale_options

)

[wandji20]

Hi @rioug
I am curious as to what the fix here should be.
I simply used local_options as per this comment

Initially, this issue was about removing duplicate English from the dropdown menu list, where @sergioosouzaa removed the souce_local that is appended to the list of the available locales (later reverted here).

Do I understand correctly that we want to show just one English (which should be thesame for other languages with multiple locals eg fr, es) in the dropdown irrespective of the number of en related locals configured?
eg With this configuration AVAILABLE_LOCALES="en_AU,es,en_US,en_BE,en_CA,es_CO,es_CR,es_US,fr_CH,fr_CA,fr_CM,fr_BE", I would expect to see just 3 languages (English, Francais, and Espanol) in the selector?

[rioug]

Fair enough I missed the comment.
I did not quite grasp the problem. From looking at it again, it looks to me to be a translation problem. For instance all the English locales are named "English" that's why we get a duplicates, so I reckon we should be fixing the translations instead.

Before moving forward, let's clarify what they meant,@mkllnk @dacook by this did you mean using non translated locale in the dropdown ? ie having something like en_AU, en_CA, fr etc.. as options ? or did you mean using locale_options in the helper here :

openfoodnetwork/app/helpers/i18n_helper.rb

Lines 4 to 8 in 0c43dd4

	def locale_options
	OpenFoodNetwork::I18nConfig.available_locales.map do |locale|
	[t('language_name', locale:), locale]
	end
	end

[dacook]

I think the issue description was a bit misleading, and the method names are even more confusing.
This is what I meant: dacook@4a9a42e

Wandji could you please try that and test if it solves the problem?

[wandji20]

@dacook
Tested the diff and now we do not get the en locale in the list
However, we still have multiple languages displayed with thesame label

I agree with @rioug that we should be fixing the translation and still use the selectable_locales here

[dacook]

Regarding the multiple "English", (or Espanol, etc), this is not a problem. It is correctly showing en, en_AU, en_UK etc. Only one of these is ever enabled on a system (if we need to enable more, then we can change the label).

The problem we're trying to solve is simply that the en language always appears, even when it is not enabled.

[dacook]

I agree with rioug that we should be fixing the translation and still use the selectable_locales here

I don't understand, do you mean that we should update i18n_config.rb (instead of i18n_helper.rb as I suggested)? As as far as I understand, available_locales has a different purpose and shouldn't be changed (as per the commnt):

openfoodnetwork/lib/open_food_network/i18n_config.rb

Lines 13 to 21 in 0c43dd4

	# Locales that can be selected by users.
	def self.selectable_locales
	ENV["AVAILABLE_LOCALES"]&.split(/[\s,]+/) || []
	end
	# All locales that can be accessed by the application, including fallbacks.
	def self.available_locales
	(selectable_locales + [default_locale, source_locale]).uniq
	end

[wandji20]

The problem we're trying to solve is simply that the en language always appears, even when it is not enabled.

For this, I have updated as discussed to use selectable_options which resolves the issue.

As far as fixing translations, I would suggest updating language_name to match the full language name where possible e.g. In config/locales/en_AU.yml we could change language_name: "English" to language_name: "English - AUSTRALIA (AU)"

[dacook]

Thanks.
So far we've never needed to have multiple English locales used at the same time (eg in Australia we only enable en_AU; in UK it's only en_UK), so we don't need to update the language_name at this time.

[drummer83]

Hi @wandji20,
Thanks for this PR! I have tested it on our staging server.

Setup of the locales on the server

Before your PR

I could reproduce the issue of duplicate English option:

Here is the source code:

After your PR

The duplicate is gone:

Here is the source code:

I checked the following:

• Check the language dropdown menu on users -> new ✔️
• Check the language dropdown menu on users -> edit ✔️
• Check the user's locale in the user account ✔️
• Check the translations that broke with the previous fix ✔️
  
  
  

Conclusion

It's looking good. I can't find any regressions. Great work!
Thanks again! Merging! 🚀