Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect successful user signup request to main home page [OFN-11597] #12639

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

wandji20
Copy link
Contributor

@wandji20 wandji20 commented Jul 3, 2024

What? Why?

Redirect successful user signup requests to the main home page

What should we test?

  1. Register on the website
  2. Check the modal closes when clicking on "sign up now" and the user is redirected to the home page
  3. The message explaining the confirmation email appears on a home page flash banner
  4. Errors messages like non matching passwords, wrong email... should be kept within the modal
  • Visit ... page.
    path: /login

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • Technical changes only

Dependencies

N/A

Documentation updates

N/A

@mkllnk mkllnk added the user facing changes Thes pull requests affect the user experience label Jul 5, 2024
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

It would have been great to add a spec for the disappearance of the modal. But the main part of the issue is around UX that needs to be manually tested anyway. So I'm happy with the pull request as is. Well done.

Testing should probably include the password manager scenario to check that the new behaviour triggers the password saving features.

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks for your help 🙏

@drummer83 drummer83 self-assigned this Jul 10, 2024
@drummer83 drummer83 added the pr-staged-au staging.openfoodnetwork.org.au label Jul 10, 2024
@drummer83
Copy link
Contributor

Hi @wandji20,
Thank you for another pull request. I have tested this one as well.

Before the PR

The message about the confirmation email was displayed within the modal and the modal stayed open:
image

After the PR

The message is now shown on the home page and the modal is being closed:
image

Error messages during signup are still displayed within the modal:
image

I have also tested the full signup process. It's working well, as before.

Results

This PR is working as expected and no regression could be found. Excellent! 💪
Merging! 🚀

Thanks again! 🙏

@drummer83 drummer83 merged commit 10898fd into openfoodfoundation:master Jul 10, 2024
52 checks passed
@drummer83 drummer83 removed the pr-staged-au staging.openfoodnetwork.org.au label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Close the login modal after sign-up and display message on home page
4 participants