-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Fix) Product description not correctly truncated #12635
Conversation
Hi @wandji20 👋 Thank you |
a9ff87c
to
8d48a0b
Compare
Hi @sigmundpetersen |
Thanks, this is now ready for review. One of our developers will come back to you if there is any feedback 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and welcome! Thanks for contribution, this looks like a good change but I think there might be an issue, can you please check?
1a07bd4
to
c1cd1de
Compare
Hi @wandji20 the main branch build is currently broken, so the build errors here after rebase are not linked to your PR 👍 |
Thank you @sigmundpetersen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
That looks like a great improvement. The confusion around this is that the original spec was to display two lines of text and truncate on the second line but nobody could make it work properly. So we decided to simplify and display only the first line of text. It looks like you fixed it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 ! thanks for your help.
Hi @wandji20, I have tested your PR on our staging server. Here is what I found. Before your PRI could reproduce the issue with incorrect truncation in width and height - even though I had to delete the HTML tags in the product description (see 'How to reproduce' above): After your PRIt's looking good in Firefox. The text is truncated correctly: I have also added an additional line break after the first sentence, which is displayed correctly as well: I have also tested the Safari 17.3 browser on Sonoma using Browserstack: SummaryIt's all looking good and I couldn't spot any regressions. 👍 Thanks again! 🙏 |
What? Why?
Set CSS white-space property to normal and unify height and line-height CSS values
What should we test?
Test possible combinations of very long product descriptions with and without line breaks to confirm text is properly truncated.
Expected result
Release notes
N/A
Changelog Category (reviewers may add a label for the release notes):
Dependencies
N/A
Documentation updates
N/A