-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Voucher Code Field Focus Issue #12634
Fix Voucher Code Field Focus Issue #12634
Conversation
- when disabling or enabling the control, we should only focus it if it's not a button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, could you update the related test as well ? thanks !
Ah, sorry about that. I missed the Jest specs. Let me update that and get back to you. Thanks. |
d52a559
to
ced3408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, and thanks for updating the existing spec to cover this also 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, It looks good now thanks !
I didn't manage to successfully stage this one :( Don't know if it is linked to the errors we are seeing in master? |
@RachL I think this is due to the same out-of-memory issue on fr-staging. |
This is how Filipe did it earlier #12485 (comment) |
@sigmundpetersen ah good to know, thanks! but Filipe has ssh access, I don't :( FYI however I've tried staging AU and it failed as well |
Yes, same error on au-staging. |
Hi @chahmedejaz, I was able to reproduce the bug BEFORE this PR. After staging your solution, I couldn't see it anymore. So I can confirms that the bug is fixed. That's great! Thank you!! 🙏 Kazam_screencast_00004.webmReady to go! 🚀 🥳 |
What? Why?
toggle_control_controller
to enable the Apply button if the voucher code is present.control
after performing some toggle action on it i.e. after enabling etc.submit
button (Apply), and when user enters the voucher code, and after that the controller enables the Apply button and focuses it. Hence, the focus is lost from the Voucher Code input field.control
is a button, then it won't be focused. Hence, the currently focused field will remain focused.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):