Update spec for quotation mark replacement #12584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why, but the pre-compiling of assets triggered Rails to render `style="..."` instead of `style='...'` in this case. But when assets are compiled on-demand, we get the single quotes. So I changed the spec to be agnostic of this detail. We actually just want to know about the link and its href.
mkllnk
added
the
technical changes only
dacook
approved these changes
Jun 19, 2024
| let(:shop) { create(:enterprise, allow_order_changes: true) } | ||
|
|
||
| let(:content) { Capybara::Node::Simple.new(body) } |
There was a problem hiding this comment.
Clever! Now we can use capybara expectations just like on a web page. ✨
🤔 I wonder if we should build this in to a mailer spec helper...
There was a problem hiding this comment.
Do you know what the style check was for? I doubt it's relevant to these test expectations so I'm happy to see it go.
There was a problem hiding this comment.
I think that it was just part of the regular expression to match the link but nothing else. It wasn't checking the style.
|
I'm going to merge, but FYI @rioug, we can use normal Capybara expectations in mailer specs ☝️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to:
I'm not sure why, but the pre-compiling of assets triggered Rails to render
style="..."instead ofstyle='...'in this case. But when assets are compiled on-demand, we get the single quotes. So I changed the spec to be agnostic of this detail. We actually just want to know about the link and its href.What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates