Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages don't block bottom of page clicks #12567

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Error messages don't block bottom of page clicks #12567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/webpacker/css/admin_v3/components/messages.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@

.flash-container {
position: fixed;
left: 0;
bottom: 0;
width: 100%;
left: 50%;
transform: translateX(-50%);
bottom: 3.5rem;
z-index: $flash-message-z-index;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could just move the z-index rule to the child .flash, so the container wouldn't cover anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that could have been a solution, too.

By the way, I noticed that the flash content seems to be there twice. Once in the flash block and then in a notice block which is perfectly overlaying the first one. It doesn't really matter right now but I guess that we want to clean that up at some point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, does that mean you have to click "dismiss" twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I didn't think of that but just tested and you are right. You have to click twice. 🤦

That's another issue, low priority though.

display: flex;
justify-content: center;
Expand All @@ -38,7 +38,6 @@
position: relative;
display: flex;
align-items: center;
bottom: 3.5rem;
padding: 0.25rem;
min-width: 24rem;
max-width: 48.25em;
Expand Down
Loading