Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecation strikethrough from tax report (by producer) #12505

Merged
merged 1 commit into from
May 23, 2024

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented May 22, 2024

Removes deprecation strikethrough from report enterprise fees with tax report by producer.

What? Why?

Context here.

What should we test?

  • login as a hub manager or superadmin
  • visit /admin/reports
  • the link for Enterprise Fees With Tax Report By Producer should have the strike-through removed:

image

  • the Inventory (on hand) should still have the strike-through styling

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 self-assigned this May 22, 2024
@filipefurtad0 filipefurtad0 changed the title Removes deprecation strikethrough from report list Removes deprecation strikethrough from tax report (by producer) May 22, 2024
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, it's official!

@dacook
Copy link
Member

dacook commented May 23, 2024

Or is it? The issue still looks blocked. I'll move to In Progress until confirmed.

@sigmundpetersen
Copy link
Contributor

Issue is unblocked

@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label May 23, 2024
@RachL
Copy link
Contributor

RachL commented May 23, 2024

Looking good :)

image

merging!

@RachL RachL merged commit 163e9b6 into openfoodfoundation:master May 23, 2024
54 checks passed
@RachL RachL removed the pr-staged-fr staging.coopcircuits.fr label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Enterprise fees w/ Tax Report by Producer] Remove deprecation styling from the reports page
5 participants