Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mail spec precompile assets for it #12490

Merged
merged 1 commit into from
May 20, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented May 17, 2024

What? Why?

Specs in spec/lib don't trigger asset compilation but this particular spec uses a mailer and needs assets.

What should we test?

  • Nothing.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

Specs in `spec/lib` don't trigger asset compilation but this particular
spec uses a mailer and needs assets.
@mkllnk mkllnk self-assigned this May 17, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label May 17, 2024
@mkllnk mkllnk marked this pull request as ready for review May 17, 2024 05:30
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix 👍

@dacook dacook merged commit b729ec3 into openfoodfoundation:master May 20, 2024
52 checks passed
@mkllnk mkllnk deleted the mail-spec branch May 28, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants