Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates tests on a regular checkout #12464

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented May 10, 2024

What? Why?

The PR updates checkout flow to the new checkout, to test variant overrides.

PS: I'm a bit weary that this spec might be introduce flakyness.

What should we test?

  • green build

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 marked this pull request as draft May 10, 2024 11:57
@filipefurtad0 filipefurtad0 force-pushed the variant_overrides_spec_to_split_checkout branch from 8218ea3 to 9c74a42 Compare May 13, 2024 15:51
@filipefurtad0 filipefurtad0 self-assigned this May 14, 2024
@filipefurtad0 filipefurtad0 added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label May 14, 2024
@filipefurtad0 filipefurtad0 force-pushed the variant_overrides_spec_to_split_checkout branch from 7b93a22 to 4e16eb9 Compare May 14, 2024 11:19
@sigmundpetersen sigmundpetersen changed the title Uptades tests on a regular checkout Updates tests on a regular checkout May 14, 2024
@filipefurtad0 filipefurtad0 marked this pull request as ready for review May 14, 2024 11:33
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mkllnk mkllnk merged commit 68f12ed into openfoodfoundation:master May 15, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants