Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tag template from link to draft release #12430

Merged
merged 1 commit into from
May 6, 2024

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented May 2, 2024

What? Why?

The release tag was pre-filled with v which was meant to help you type the release number. But I observed multiple times now that an actual tag named v was created. That tag can be quite annoying in the history.

So let's remove this tiny help to avoid mistakes. I personally use script/release/tag which pre-fills the next tag already.

[skip ci]

What should we test?

  • Nothing.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

The release tag was pre-filled with `v` which was meant to help you type
the release number. But I observed multiple times now that an actual tag
named `v` was created. That tag can be quite annoying in the history.

So let's remove this tiny help to avoid mistakes. I personally use
`script/release/tag` which pre-fills the next tag already.

[skip ci]
@mkllnk mkllnk self-assigned this May 2, 2024
@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label May 2, 2024
@mkllnk mkllnk marked this pull request as ready for review May 2, 2024 02:05
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a minute to understand what the issue was, it's about the tag v being created not about tag starting with v ... I am probably guilty of that mistake 👍

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dacook dacook merged commit 84da904 into openfoodfoundation:master May 6, 2024
2 checks passed
@mkllnk mkllnk deleted the draft-release branch May 8, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants